add configuration to process function#72
Merged
ipmach merged 8 commits intodevelopmentfrom Mar 10, 2026
Merged
Conversation
Contributor
|
@viktorbeck98 can you provide a small script of how to run it? So I can verify that everything works as it suppose to and to check if the unit tests cover all cases? :) |
Collaborator
Author
|
@ipmach I added more tests. One of which should be descriptive enough for you to check if it works correctly: |
ipmach
approved these changes
Mar 10, 2026
Contributor
ipmach
left a comment
ipmach
left a comment
There was a problem hiding this comment.
process method from the coreComponent is becaming a little messy and that can backfire us in the future. I will add an issue about it but approve the keep working in the demos.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.