Run filesize comparisons if not running in streaming mode.#20
Open
rmathure wants to merge 1 commit intoallanlei:masterfrom
Open
Run filesize comparisons if not running in streaming mode.#20rmathure wants to merge 1 commit intoallanlei:masterfrom
rmathure wants to merge 1 commit intoallanlei:masterfrom
Conversation
|
Hi, I've encountered the same issue. Fix recommended by rmathure works for me as well. Request that the pull request be approved or the base code updated. Thanks! |
Author
|
Any updates on this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When streaming zip content using SMBHandler and not writing the data to a file(streaming data out instead), the check at https://github.com/allanlei/python-zipstream/blob/master/zipstream/__init__.py#L328 detects that the data transferred (filesize) is greater than ZIP64_LIMIT. The Zip64 flag even after being set during initialization, has the variable zip64 set to False which cause the RuntimeError 'File size has increased during compressing'.
This is my proposed solution: We should only check the file size or the compress size when we are writing to a file i.e. filename is specified.
This solution works for my use case where I am streaming in/out data but I leave the actual implementation to fix this bug to the authors.