Removing call to basicConfig

[timmarkhuff]

I noticed while using this library that it makes a call to logging.basicConfig. I don't believe libraries should do this. logging.basicConfig should be called only once per runtime. Our software is trying to use python-ws-discovery, and we are finding that it is overriding our logging config.

[timmarkhuff]

@andreikop , do you have any thoughts on this?

[andreikop]

@timmarkhuff, very good point.
Make a PR. I'll accept and release

[timmarkhuff]

@timmarkhuff, very good point.

Make a PR. I'll accept and release

This is the PR. Is it sufficient?

[andreikop]

Ah, sorry, it was already PR and not a discussion.
Taking deeper look.
discover and publish are both command line entrypoints and setting up logging here is absolutely relevant.
The issue - the same functions are cmdline entrypoints and actually do the job.
I think basicConfig() shall remain at both those functions, but the code shall be refactored to move actual implementation to public API module. So, your application would not call wsdiscovery.cmdline.discover but wsdiscovery.discover.

wsdiscovery.discover shall be implemented in wsdiscovery.api and imported to both wsdiscovery top level module and to wsdiscovery.cmdline entrypoint. The same for publish API.

@timmarkhuff does it make sence? Could you do this refactoring?

[timmarkhuff]

After looking at this more closely, I don't think the problem is with python-ws-discovery at all. The call to logging.basicConfig is in the cmdline.py file which isn't being called by our library. And as you said, it makes sense to have it in that file anyway.

I think the problem is with python-onvif that you use. I submitted a PR there, but there has been no activity on that repo for 5 years, so I'm not sure if anyone will see it.

[andreikop]

OK, closing this PR. But moving code from cmdline functions seems relevant. New PR is welcome.