Draft
Conversation
Contributor
|
I did this same fix in some of the ITs that I was working on recently, and I was wondering if we were going to have to move this up into some higher level code. May want to remove the references to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seeing exceptions like the following when running ITs. This exception does not cause the test to fail, it is just printed after the test runs. The reason it happens is the code ServerKeywordExecutable.getConfiguration() is run w/o the java system property for accumulo.properties set. So it searches and finds
test/src/main/resources/accumulo.propertieson the classpath which does not containinstance.volumes. This fix sets the java system property so that accumulo.properties created by mini is found. Opening this as draft for the moment because I am not sure if this is the best way to fix this (feels a bit hacky).