Conversation
|
According to an old discussion in the SQLA repo,
In SQLA2.1 this api was finally marked as private and
Thoughts? |
|
Thanks for runnig it @Dev-iL -> really cool you are doing it !
We only seem to use from sqlalchemy_utils import UUIDTypeI guess in sqlalchemy 2.+ there should be already an alternative type we can use ? https://docs.sqlalchemy.org/en/21/core/custom_types.html#backend-agnostic-guid-type
Not sure about compatibility, but I would imagine it should be quite easy to replace it |
|
@potiuk Thanks for the tip! I think we might be able to remove both of these dependencies: |
02201e3 to
1fcfcb9
Compare
|
@jscheffl Do you see any issue with modifying the old migrations so we can move to new ORM type hints? The DB should stay the same (if I did everything right). The SQLA docs mention that:
So here's what I think:
|
1fcfcb9 to
01552b8
Compare
I do not see an issue in this except (1) testing and (2) review. But all looks like simple subsitutes. So OK for me. |
How to test this besides adding the |
Mhm, yeah taking a Airflow 2.7.0 setup and run the migration :-) Such integrative tests are not in CI in my view. |
Isn't that what the migration tests (e.g. this) do? |
Ah... yeah ... 🤦 |
01552b8 to
d3e06bc
Compare
|
This addresses the issue with the snowflake provider. |
This PR is intended to ensure compatibility with SQLA2.1.
The plan is as follows:
Latest SQLAlchemy test: coreandLatest SQLAlchemy test: providerstasks.ScalarAttributeImplon SQLA2.1 kvesteri/sqlalchemy-utils#804Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.