Skip to content

Copy http headers from main controller to sub controllers #3213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chenBright wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −1
Open

Copy http headers from main controller to sub controllers #3213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/brpc/parallel_channel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -724,6 +724,9 @@ void ParallelChannel::CallMethod(
ParallelChannelDone::SubDone* sd = d->sub_done(j++);
// Forward the attachment to each sub call
sd->cntl.request_attachment().append(cntl->request_attachment());
if (PROTOCOL_HTTP == cntl->request_protocol()) {
Copy link
Contributor

@wwbmmm wwbmmm Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current ParallelChannel is not friendly to http protocol if user want to set different http request params for different sub call.

sd->cntl.http_request() = cntl->http_request();
}
_chans[i].chan->CallMethod(sd->ap.method, &sd->cntl,
sd->ap.request, sd->ap.response, sd);
}
Expand Down
4 changes: 3 additions & 1 deletion src/brpc/selective_channel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,9 @@ int Sender::IssueRPC(int64_t start_realtime_us) {
sub_cntl->set_request_code(_main_cntl->request_code());
// Forward request attachment to the subcall
sub_cntl->request_attachment().append(_main_cntl->request_attachment());
sub_cntl->http_request() = _main_cntl->http_request();
if (PROTOCOL_HTTP == _main_cntl->request_protocol()) {
Copy link
Contributor

@wwbmmm wwbmmm Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this can also apply to PROTOCOL_H2

sub_cntl->http_request() = _main_cntl->http_request();
}

sel_out.channel()->CallMethod(_main_cntl->_method,
&r.sub_done->_cntl,
Expand Down
Loading