CAUSEWAY-3971: Switching between Layout Variants may result in Members staying hidden#3426
Merged
andi-huber merged 24 commits intomainfrom Mar 4, 2026
Merged
CAUSEWAY-3971: Switching between Layout Variants may result in Members staying hidden#3426andi-huber merged 24 commits intomainfrom
andi-huber merged 24 commits intomainfrom
Conversation
andi-huber
commented
Feb 24, 2026
...tamodel/src/main/java/org/apache/causeway/core/metamodel/facets/object/grid/BSGridFacet.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Contributor
Author
|
Contributor
Author
Modify the Facet Ranking logic, such that we can optionally find the winning |
correctly (tests)
HasDynamicallyVisibleContent
(XmlLayoutRespectingFacetModifier)
andi-huber
force-pushed
the
3971-layout.switching
branch
from
b5bebab to
12d0503
Compare
andi-huber
commented
Mar 2, 2026
core/metamodel/src/main/java/org/apache/causeway/core/metamodel/facetapi/FacetHolderSimple.java
Outdated
Show resolved
Hide resolved
andi-huber
commented
Mar 2, 2026
core/metamodel/src/main/java/org/apache/causeway/core/metamodel/facetapi/FacetRanking.java
Outdated
Show resolved
Hide resolved
andi-huber
commented
Mar 2, 2026
core/metamodel/src/main/java/org/apache/causeway/core/metamodel/util/Facets.java
Outdated
Show resolved
Hide resolved
andi-huber
commented
Mar 2, 2026
core/mmtest/src/test/java/org/apache/causeway/core/metamodel/services/grid/GridLoadingTest.java
Outdated
Show resolved
Hide resolved
captures the various lanes per facet rank hello world reproducer is looking good now
- use EnumMap for performance
qualified filter (e.g. wicket)
andi-huber
force-pushed
the
3971-layout.switching
branch
2 times, most recently
from
4e4fcf7 to
c0971f6
Compare
andi-huber
force-pushed
the
3971-layout.switching
branch
from
c0971f6 to
fd510f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analysis so far:
There is only one instance of
ObjectSpecificationper DomainObject class. When a layout gets loaded the first time a bunch of layout related Facets within saidObjectSpecificationreceive an update to reflect layout data from this new layout.xml.Those layout related facets are stateful and their state depends on the layout that was last loaded. With caching involved, loading only happens once per application lifecycle (PROD mode).
Hence, layout switching does not work as desired. Even worse, in a multi-user environment all sorts of weird layout issues might occur, not only related to member hiding.
We need qualifier support for layout related facets:
Remaining Technical Challenges:
String) for the current page/request.FacetRankingneeds to honor the currently set layout variant properly.Task-Url: https://issues.apache.org/jira/browse/CAUSEWAY-3971