feat: support Spark format_string expression#3588
Open
n0r0shi wants to merge 1 commit intoapache:mainfrom
Open
feat: support Spark format_string expression#3588n0r0shi wants to merge 1 commit intoapache:mainfrom
n0r0shi wants to merge 1 commit intoapache:mainfrom
Conversation
Register datafusion-spark's FormatStringFunc UDF and add serde mapping in stringExpressions.
andygrove
reviewed
Feb 25, 2026
Member
andygrove
left a comment
There was a problem hiding this comment.
Clean serde wiring. The CometScalarFunction approach and UDF registration look correct.
For the tests, it would be a good fit to use the SQL file framework instead of CometStringExpressionSuite. There are already many string expression SQL files in spark/src/test/resources/sql-tests/expressions/string/. A format_string.sql file there would automatically compare Spark and Comet results.
It might also be worth adding a test with %f for floating-point formatting, since Spark uses java.util.Formatter with US locale and there could be subtle differences in how Rust formats floats. Something like format_string('%.2f', 3.14159) would exercise that path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
format_stringfrom thedatafusion-sparkcrate (FormatStringFunc) to Cometjni_api.rsand add serde mapping viaCometScalarFunctioninQueryPlanSerde.scalaTest plan
CometStringExpressionSuite— passes