feat: support make_dt_interval and make_interval expressions#3591
feat: support make_dt_interval and make_interval expressions#3591n0r0shi wants to merge 1 commit intoapache:mainfrom
Conversation
Register datafusion-spark's SparkMakeDtInterval and SparkMakeInterval UDFs and add serde mappings in temporalExpressions.
|
Thanks for wiring up these two expressions. The serde and registration changes look correct to me. I have a couple of suggestions on the test side. The project has been moving expression tests to the SQL file-based framework ( It would also be good to add some null handling coverage. Both expressions are null-intolerant per the Spark spec, so testing with NULL column values (not just non-null data) would help catch any issues. Something like inserting a row with NULLs in the test table would do it. |
|
Test failure: |
Summary
make_dt_intervalandmake_intervalexpressionsdatafusion-sparkcrate, so this is serde-only wiringTest plan
CometTemporalExpressionSuite