Skip to content

BloomFilterBuilder.validateSizeInputs should not accept numBits=0 #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tisonkun merged 1 commit into from
Feb 11, 2026
Merged

BloomFilterBuilder.validateSizeInputs should not accept numBits=0 #725

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/apache/datasketches/filters/bloomfilter/BloomFilterBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ private static void validateAccuracyInputs(final long maxDistinctItems, final do
}

private static void validateSizeInputs(final long numBits, final int numHashes) {
if (numBits < 0) {
if (numBits <= 0) {
throw new SketchesArgumentException("Size of BloomFilter must be strictly positive. "
+ "Requested: " + numBits);
}
Expand Down
Loading