chore: cleanup and fix partial update in python#292
Merged
luoyuxia merged 2 commits intoapache:mainfrom Feb 9, 2026
Merged
Conversation
cb3b6be to
ea17569
Compare
ea17569 to
0697b92
Compare
Contributor
Author
|
@luoyuxia PTAL 🙏 |
Contributor
leekeiabstraction
left a comment
There was a problem hiding this comment.
TY for the PR! Added small comment
Contributor
Author
|
@leekeiabstraction TY for the review. Addressed comment. PTAL 🙏 |
luoyuxia
approved these changes
Feb 9, 2026
There was a problem hiding this comment.
Pull request overview
This PR improves the Python bindings by fixing partial-update row handling, cleaning up row conversion utilities, and exposing a “latest offset” constant consistently across Rust core and Python.
Changes:
- Added
LATEST_OFFSETconstant to Rust core and exposed it in the Python module + type stubs. - Fixed Python upsert/delete/lookup row conversion by introducing a sparse-row conversion path for partial updates and PK-only inputs.
- Updated Python typing/docs and expanded the example script with partial-update verification.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/fluss/src/client/table/mod.rs | Adds LATEST_OFFSET constant in the core client table module. |
| bindings/python/src/lib.rs | Exposes LATEST_OFFSET to Python via the extension module. |
| bindings/python/src/upsert.rs | Stores/resolves partial-update target columns and uses sparse row conversion for partial upserts + PK deletes. |
| bindings/python/src/table.rs | Refactors row conversion into python_to_sparse_generic_row and reuses it for full-row conversion. |
| bindings/python/src/lookup.rs | Uses sparse row conversion for PK lookups. |
| bindings/python/fluss/init.pyi | Updates stubs/docs: supported types list + adds LATEST_OFFSET. |
| bindings/python/example/example.py | Adds example code to verify partial update behavior by names and indices. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cleanup and partial updates fix(discovered during writing doc):