Skip to content

fix: use std::move when pass by value #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SYaoJun wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use std::move when pass by value #555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@ meson==1.3.0
ninja==1.13.0
mkdocs==1.6.1
mkdocs-material==9.6.22
pre-commit==4.5.1
Copy link
Member

@mapleFU mapleFU Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this related?

7 changes: 5 additions & 2 deletions src/iceberg/util/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,13 @@ class ConfigBase {
template <typename T>
class Entry {
public:
Entry(std::string key, const T& val,
Entry(std::string key, T val,
std::function<std::string(const T&)> to_str = internal::DefaultToString<T>,
std::function<T(const std::string&)> from_str = internal::DefaultFromString<T>)
: key_{std::move(key)}, default_{val}, to_str_{to_str}, from_str_{from_str} {}
: key_{std::move(key)},
default_{std::move(val)},
to_str_{std::move(to_str)},
from_str_{std::move(from_str)} {}

private:
const std::string key_;
Expand Down
4 changes: 2 additions & 2 deletions src/iceberg/util/lazy.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,10 @@ class Lazy {

template <typename R, typename... Args>
struct Trait<R (*)(Args...)> {
using ReturnType = R::value_type;
using ReturnType = typename R::value_type;
Copy link
Contributor

@HuaHuaY HuaHuaY Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a warning from clang-tidy? I guess that typename may be duplicate here.

Copy link
Author

@SYaoJun SYaoJun Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, clang-tidy suggest that. I think it is more straightforward if added.

Copy link
Contributor

@HuaHuaY HuaHuaY Feb 6, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to cppreference(https://en.cppreference.com/w/cpp/language/dependent_name.html), a dependent qualified name is assumed to name a type and no typename is required when a qualified name that appears in type-id, where the smallest enclosing type-id is the type-id in an alias declaration since C++20. Can you show the rule name when you meet clang-tidy warning?

};

using T = Trait<decltype(InitFunc)>::ReturnType;
using T = typename Trait<decltype(InitFunc)>::ReturnType;

public:
template <typename... Args>
Expand Down
Loading