perf(reader): Add Parquet metadata size hint option to ArrowReaderBuilder#2173
Open
mbutrovich wants to merge 2 commits intoapache:mainfrom
Open
perf(reader): Add Parquet metadata size hint option to ArrowReaderBuilder#2173mbutrovich wants to merge 2 commits intoapache:mainfrom
mbutrovich wants to merge 2 commits intoapache:mainfrom
Conversation
mbutrovich
changed the title
kevinjqliu
approved these changes
Feb 24, 2026
Contributor
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM,
so we are exposing metadata_size_hint in ArrowReader so that it can be passed to ArrowFileReader?
Collaborator
Author
|
Thanks for the quick review @kevinjqliu! Hopefully someone can hook this up to the front-end in the presence of information from elsewhere like Puffin files, or a config for a default value. Comet will make use of this quickly! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Add
with_metadata_size_hinttoArrowReaderBuilder, allowing callers to configure the number of bytes to prefetch when reading Parquet footer metadata. No default is set—callers opt in via the builder. When unset, behavior is unchanged.Are these changes tested?
Existing tests.