Draft
Conversation
… prevent closing FileIO on executor
nastra
force-pushed
the
remote-planning-file-io-in-tasks
branch
3 times, most recently
from
b6c4c10 to
cb1a99f
Compare
nastra
force-pushed
the
remote-planning-file-io-in-tasks
branch
from
cb1a99f to
67f317c
Compare
Comment on lines
+235
to
+236
| toTaskGroupIterable( | ||
| groupingKey, groupingKeyTasks, splitSize, lookback, weightFunc, fileIO)); |
Contributor
There was a problem hiding this comment.
TG would a split in executor, i wonder if we should send it at FileIO per split ? but i can see how it can simplify, thinking of it more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.