Skip to content

Core: Add properties to InMemoryFileIO#15469

Merged
huaxingao merged 1 commit intoapache:mainfrom
nastra:inmemory-props
Feb 27, 2026
Merged

Core: Add properties to InMemoryFileIO#15469
huaxingao merged 1 commit intoapache:mainfrom
nastra:inmemory-props

Conversation

@nastra
Copy link
Contributor

@nastra nastra commented Feb 27, 2026

Technically InMemoryFileIO doesn't have properties, so this is mainly being added to make testing FileIO properties easier/possible for #15368

@nastra nastra requested a review from danielcweeks February 27, 2026 16:53
@github-actions github-actions bot added the core label Feb 27, 2026
Copy link
Contributor

@danielcweeks danielcweeks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@singhpk234 singhpk234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too !

@huaxingao huaxingao merged commit 1a20b54 into apache:main Feb 27, 2026
34 checks passed
@huaxingao
Copy link
Contributor

Thanks @nastra for the PR! Thansks @danielcweeks @singhpk234 for the review!

@nastra nastra deleted the inmemory-props branch February 27, 2026 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants