Conversation
Purging one topic while a sibling retained messages reported zero messages for the entire stream via get_stats(). The zero_out chain used store(0) at each tier and then called zero_out on the parent, blanking the entire ancestor chain rather than subtracting the purged child's contribution. Replace store(0) with swap(0) + parent.decrement(prev) so each tier only subtracts its own value. Remove the redundant topic-level zero_out from purge_topic — partition zeroing already propagates correctly through the hierarchy.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2736 +/- ##
============================================
- Coverage 68.58% 68.55% -0.03%
Complexity 585 585
============================================
Files 735 735
Lines 60370 60342 -28
Branches 56783 56755 -28
============================================
- Hits 41403 41366 -37
- Misses 16941 16950 +9
Partials 2026 2026
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
spetz
approved these changes
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purging one topic while a sibling retained messages reported
zero messages for the entire stream via get_stats(). The
zero_out chain used store(0) at each tier and then called
zero_out on the parent, blanking the entire ancestor chain
rather than subtracting the purged child's contribution.
Replace store(0) with swap(0) + parent.decrement(prev) so
each tier only subtracts its own value. Remove the redundant
topic-level zero_out from purge_topic — partition zeroing
already propagates correctly through the hierarchy.