Build Win32 setup only with Unicode support. #470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Non-unicode ("ANSI") functions were apparently needed only for
supporting Windows 9X, that is not our priority any more.
This simplifies the internal structure of the setup executable.
Member
|
I fixed some empty lines at the file ending... |
Member
|
I tried to build but it complains about a missing "setup_main.hxx"? |
Contributor
Author
This must be because file Please try removing directory |
Member
|
Builds and installs now. |
Member
|
Could this probably fix this bug? |
Contributor
Author
Unfortunately, I don't think so... this PR is about removing code that was supposed to run only under Windows 9x. |
ardovm
added a commit
to ardovm/openoffice
that referenced
this pull request
Feb 7, 2026
Build Win32 setup only with Unicode support.
Non-unicode ("ANSI") functions were apparently needed only for
supporting Windows 9X, that is not our priority any more.
This simplifies the internal structure of the setup executable.
Co-authored-by: Matthias Seidel <mseidel@apache.org>
(cherry picked from commit fc73561)
ardovm
added a commit
to ardovm/openoffice
that referenced
this pull request
Feb 8, 2026
Build Win32 setup only with Unicode support.
Non-unicode ("ANSI") functions were apparently needed only for
supporting Windows 9X, that is not our priority any more.
This simplifies the internal structure of the setup executable.
Co-authored-by: Matthias Seidel <mseidel@apache.org>
(cherry picked from commit fc73561)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-unicode ("ANSI") functions were apparently needed only for supporting Windows 9X, that is not our priority any more.
This simplifies the internal structure of the setup executable.