HDDS-12785. Add an option to disable lifecycle configuration from OM#9638
Open
chungen0126 wants to merge 4 commits intoapache:HDDS-8342from
Open
HDDS-12785. Add an option to disable lifecycle configuration from OM#9638chungen0126 wants to merge 4 commits intoapache:HDDS-8342from
chungen0126 wants to merge 4 commits intoapache:HDDS-8342from
Conversation
Contributor
Gargi-jais11
left a comment
Gargi-jais11
left a comment
There was a problem hiding this comment.
Thanks @chungen0126 for the patch.
Please find inline comment.
Comment on lines
+1114
to
+1115
| throw new OMException("OM Lifecycle feature is not enabled. Please " | ||
| + "set ozone.om.lifecycle.service.enabled to true and restart all OMs.", |
Contributor
There was a problem hiding this comment.
Please use OZONE_KEY_LIFECYCLE_SERVICE_ENABLED instead of hardcoding it.
throw new OMException("OM Lifecycle feature is not enabled. Please set " + OZONE_KEY_LIFECYCLE_SERVICE_ENABLED + "to true and restart all OMs."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR introduces a configuration check to disable the Lifecycle feature in Ozone Manager.
FEATURE_NOT_ENABLED.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-12785
How was this patch tested?
Added
TestOMDisableLifecycleto verify:ci: https://github.com/chungen0126/ozone/actions/runs/21053143860