-
Notifications
You must be signed in to change notification settings - Fork 1
Remove tracing #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove tracing #60
Conversation
WalkthroughRemoved OpenTelemetry tracing: deleted span collection classes, removed tracing configuration and fields, stripped spans/traceId from logging APIs and DTOs, updated caller code and tests accordingly. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (3)
src/main/java/io/apitally/common/RequestLogger.java (1)
12-12: Remove unused import.The
SpanDataimport is no longer used after removing tracing functionality. This is likely causing the Spotless formatting check failure.🧹 Proposed fix
-import io.apitally.common.dto.SpanData;src/main/java/io/apitally/spring/ApitallyFilter.java (1)
13-13: Remove unused import.The
SpanDataimport is no longer used after removing span tracing functionality from the filter.🧹 Proposed fix
-import io.apitally.common.dto.SpanData;src/test/java/io/apitally/common/RequestLoggerTest.java (1)
14-14: Remove unused import.The
SpanDataimport is no longer used after removing tracing-related test code. This is likely contributing to the Spotless formatting check failure.🧹 Proposed fix
-import io.apitally.common.dto.SpanData;
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60 +/- ##
============================================
- Coverage 79.15% 77.63% -1.52%
+ Complexity 410 365 -45
============================================
Files 39 37 -2
Lines 1396 1252 -144
Branches 172 153 -19
============================================
- Hits 1105 972 -133
- Misses 189 196 +7
+ Partials 102 84 -18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f360021 to
b3d020d
Compare
Summary by CodeRabbit
Removed Features
Configuration Changes
Documentation