Changing BLE HCI transport to spi for Nina based devices by andreagilardoni · Pull Request #380 · arduino-libraries/ArduinoBLE

andreagilardoni · 2025-01-15T13:42:16Z

This feature depends on the following PR arduino/nina-fw#99, introducing breaking changes in ArduinoBLE library

github-actions · 2025-01-15T13:47:26Z

Memory usage change @ e9febff

Board	flash	%	RAM for global variables	%
`arduino:mbed_nano:nano33ble`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:renesas_uno:unor4wifi`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0

Click for full report table

Board	`examples/Central/LedControl` flash	%	`examples/Central/LedControl` RAM for global variables	%	`examples/Central/PeripheralExplorer` flash	%	`examples/Central/PeripheralExplorer` RAM for global variables	%	`examples/Central/Scan` flash	%	`examples/Central/Scan` RAM for global variables	%	`examples/Central/ScanCallback` flash	%	`examples/Central/ScanCallback` RAM for global variables	%	`examples/Central/SensorTagButton` flash	%	`examples/Central/SensorTagButton` RAM for global variables	%	`examples/Peripheral/Advertising/EnhancedAdvertising` flash	%	`examples/Peripheral/Advertising/EnhancedAdvertising` RAM for global variables	%	`examples/Peripheral/Advertising/RawDataAdvertising` flash	%	`examples/Peripheral/Advertising/RawDataAdvertising` RAM for global variables	%	`examples/Peripheral/BatteryMonitor` flash	%	`examples/Peripheral/BatteryMonitor` RAM for global variables	%	`examples/Peripheral/ButtonLED` flash	%	`examples/Peripheral/ButtonLED` RAM for global variables	%	`examples/Peripheral/CallbackLED` flash	%	`examples/Peripheral/CallbackLED` RAM for global variables	%	`examples/Peripheral/EncryptedBatteryMonitor` flash	%	`examples/Peripheral/EncryptedBatteryMonitor` RAM for global variables	%	`examples/Peripheral/LED` flash	%	`examples/Peripheral/LED` RAM for global variables	%
`arduino:mbed_nano:nano33ble`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:renesas_uno:unor4wifi`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0

Click for full report CSV

Board,examples/Central/LedControl<br>flash,%,examples/Central/LedControl<br>RAM for global variables,%,examples/Central/PeripheralExplorer<br>flash,%,examples/Central/PeripheralExplorer<br>RAM for global variables,%,examples/Central/Scan<br>flash,%,examples/Central/Scan<br>RAM for global variables,%,examples/Central/ScanCallback<br>flash,%,examples/Central/ScanCallback<br>RAM for global variables,%,examples/Central/SensorTagButton<br>flash,%,examples/Central/SensorTagButton<br>RAM for global variables,%,examples/Peripheral/Advertising/EnhancedAdvertising<br>flash,%,examples/Peripheral/Advertising/EnhancedAdvertising<br>RAM for global variables,%,examples/Peripheral/Advertising/RawDataAdvertising<br>flash,%,examples/Peripheral/Advertising/RawDataAdvertising<br>RAM for global variables,%,examples/Peripheral/BatteryMonitor<br>flash,%,examples/Peripheral/BatteryMonitor<br>RAM for global variables,%,examples/Peripheral/ButtonLED<br>flash,%,examples/Peripheral/ButtonLED<br>RAM for global variables,%,examples/Peripheral/CallbackLED<br>flash,%,examples/Peripheral/CallbackLED<br>RAM for global variables,%,examples/Peripheral/EncryptedBatteryMonitor<br>flash,%,examples/Peripheral/EncryptedBatteryMonitor<br>RAM for global variables,%,examples/Peripheral/LED<br>flash,%,examples/Peripheral/LED<br>RAM for global variables,%
arduino:mbed_nano:nano33ble,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:renesas_uno:unor4wifi,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

nina based devices will be supported through nina spi transport changing the macro from exclusion to explicit inclusion

Since automatically excluded from previous exclusion preprocessor if

Since in the next version for BLE we are delivering HCI commands through spi we don't need to restart the nina device for ble to run, thus removing those commands from this library

github-actions · 2025-01-15T14:11:05Z

Memory usage change @ 2d56544

Board	flash	%	RAM for global variables	%
`arduino:mbed_nano:nano33ble`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:renesas_uno:unor4wifi`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0

Click for full report table

Board	`examples/Central/LedControl` flash	%	`examples/Central/LedControl` RAM for global variables	%	`examples/Central/PeripheralExplorer` flash	%	`examples/Central/PeripheralExplorer` RAM for global variables	%	`examples/Central/Scan` flash	%	`examples/Central/Scan` RAM for global variables	%	`examples/Central/ScanCallback` flash	%	`examples/Central/ScanCallback` RAM for global variables	%	`examples/Central/SensorTagButton` flash	%	`examples/Central/SensorTagButton` RAM for global variables	%	`examples/Peripheral/Advertising/EnhancedAdvertising` flash	%	`examples/Peripheral/Advertising/EnhancedAdvertising` RAM for global variables	%	`examples/Peripheral/Advertising/RawDataAdvertising` flash	%	`examples/Peripheral/Advertising/RawDataAdvertising` RAM for global variables	%	`examples/Peripheral/BatteryMonitor` flash	%	`examples/Peripheral/BatteryMonitor` RAM for global variables	%	`examples/Peripheral/ButtonLED` flash	%	`examples/Peripheral/ButtonLED` RAM for global variables	%	`examples/Peripheral/CallbackLED` flash	%	`examples/Peripheral/CallbackLED` RAM for global variables	%	`examples/Peripheral/EncryptedBatteryMonitor` flash	%	`examples/Peripheral/EncryptedBatteryMonitor` RAM for global variables	%	`examples/Peripheral/LED` flash	%	`examples/Peripheral/LED` RAM for global variables	%
`arduino:mbed_nano:nano33ble`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:renesas_uno:unor4wifi`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0

Click for full report CSV

Board,examples/Central/LedControl<br>flash,%,examples/Central/LedControl<br>RAM for global variables,%,examples/Central/PeripheralExplorer<br>flash,%,examples/Central/PeripheralExplorer<br>RAM for global variables,%,examples/Central/Scan<br>flash,%,examples/Central/Scan<br>RAM for global variables,%,examples/Central/ScanCallback<br>flash,%,examples/Central/ScanCallback<br>RAM for global variables,%,examples/Central/SensorTagButton<br>flash,%,examples/Central/SensorTagButton<br>RAM for global variables,%,examples/Peripheral/Advertising/EnhancedAdvertising<br>flash,%,examples/Peripheral/Advertising/EnhancedAdvertising<br>RAM for global variables,%,examples/Peripheral/Advertising/RawDataAdvertising<br>flash,%,examples/Peripheral/Advertising/RawDataAdvertising<br>RAM for global variables,%,examples/Peripheral/BatteryMonitor<br>flash,%,examples/Peripheral/BatteryMonitor<br>RAM for global variables,%,examples/Peripheral/ButtonLED<br>flash,%,examples/Peripheral/ButtonLED<br>RAM for global variables,%,examples/Peripheral/CallbackLED<br>flash,%,examples/Peripheral/CallbackLED<br>RAM for global variables,%,examples/Peripheral/EncryptedBatteryMonitor<br>flash,%,examples/Peripheral/EncryptedBatteryMonitor<br>RAM for global variables,%,examples/Peripheral/LED<br>flash,%,examples/Peripheral/LED<br>RAM for global variables,%
arduino:mbed_nano:nano33ble,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:renesas_uno:unor4wifi,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

andreagilardoni · 2025-01-16T09:46:16Z

CI now is failing because it requires the release of WiFiNina library

github-actions · 2025-01-16T09:51:01Z

Memory usage change @ 999e9d7

Board	flash	%	RAM for global variables	%
`arduino:mbed_nano:nano33ble`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:renesas_uno:unor4wifi`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0

Click for full report table

Board	`examples/Central/LedControl` flash	%	`examples/Central/LedControl` RAM for global variables	%	`examples/Central/PeripheralExplorer` flash	%	`examples/Central/PeripheralExplorer` RAM for global variables	%	`examples/Central/Scan` flash	%	`examples/Central/Scan` RAM for global variables	%	`examples/Central/ScanCallback` flash	%	`examples/Central/ScanCallback` RAM for global variables	%	`examples/Central/SensorTagButton` flash	%	`examples/Central/SensorTagButton` RAM for global variables	%	`examples/Peripheral/Advertising/EnhancedAdvertising` flash	%	`examples/Peripheral/Advertising/EnhancedAdvertising` RAM for global variables	%	`examples/Peripheral/Advertising/RawDataAdvertising` flash	%	`examples/Peripheral/Advertising/RawDataAdvertising` RAM for global variables	%	`examples/Peripheral/BatteryMonitor` flash	%	`examples/Peripheral/BatteryMonitor` RAM for global variables	%	`examples/Peripheral/ButtonLED` flash	%	`examples/Peripheral/ButtonLED` RAM for global variables	%	`examples/Peripheral/CallbackLED` flash	%	`examples/Peripheral/CallbackLED` RAM for global variables	%	`examples/Peripheral/EncryptedBatteryMonitor` flash	%	`examples/Peripheral/EncryptedBatteryMonitor` RAM for global variables	%	`examples/Peripheral/LED` flash	%	`examples/Peripheral/LED` RAM for global variables	%
`arduino:mbed_nano:nano33ble`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:renesas_uno:unor4wifi`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0

Click for full report CSV

Board,examples/Central/LedControl<br>flash,%,examples/Central/LedControl<br>RAM for global variables,%,examples/Central/PeripheralExplorer<br>flash,%,examples/Central/PeripheralExplorer<br>RAM for global variables,%,examples/Central/Scan<br>flash,%,examples/Central/Scan<br>RAM for global variables,%,examples/Central/ScanCallback<br>flash,%,examples/Central/ScanCallback<br>RAM for global variables,%,examples/Central/SensorTagButton<br>flash,%,examples/Central/SensorTagButton<br>RAM for global variables,%,examples/Peripheral/Advertising/EnhancedAdvertising<br>flash,%,examples/Peripheral/Advertising/EnhancedAdvertising<br>RAM for global variables,%,examples/Peripheral/Advertising/RawDataAdvertising<br>flash,%,examples/Peripheral/Advertising/RawDataAdvertising<br>RAM for global variables,%,examples/Peripheral/BatteryMonitor<br>flash,%,examples/Peripheral/BatteryMonitor<br>RAM for global variables,%,examples/Peripheral/ButtonLED<br>flash,%,examples/Peripheral/ButtonLED<br>RAM for global variables,%,examples/Peripheral/CallbackLED<br>flash,%,examples/Peripheral/CallbackLED<br>RAM for global variables,%,examples/Peripheral/EncryptedBatteryMonitor<br>flash,%,examples/Peripheral/EncryptedBatteryMonitor<br>RAM for global variables,%,examples/Peripheral/LED<br>flash,%,examples/Peripheral/LED<br>RAM for global variables,%
arduino:mbed_nano:nano33ble,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:renesas_uno:unor4wifi,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

codestyle unification

7ff2838

andreagilardoni requested a review from pennam January 15, 2025 13:42

andreagilardoni added 3 commits January 15, 2025 14:57

HCI Uart changing supported devices

b542628

nina based devices will be supported through nina spi transport changing the macro from exclusion to explicit inclusion

removing mbed devices from uart transport

8a7a2a1

Since automatically excluded from previous exclusion preprocessor if

changing paradigm for BLE local device

4fa765b

Since in the next version for BLE we are delivering HCI commands through spi we don't need to restart the nina device for ble to run, thus removing those commands from this library

andreagilardoni force-pushed the ble-vhci-over-spi branch from e9febff to 1fff39a Compare January 15, 2025 13:59

andreagilardoni added 2 commits January 15, 2025 15:00

enabling hci through spi commands

ff6ebfa

Adding dependency to WiFiNINA for boards using nina

2d56544

andreagilardoni force-pushed the ble-vhci-over-spi branch from 1fff39a to 2d56544 Compare January 15, 2025 14:00

andreagilardoni force-pushed the ble-vhci-over-spi branch from 973ca70 to a96f2ab Compare January 15, 2025 14:22

fixing ci for nina based boards

999e9d7

andreagilardoni force-pushed the ble-vhci-over-spi branch from 87898dd to 999e9d7 Compare January 16, 2025 09:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changing BLE HCI transport to spi for Nina based devices#380

Changing BLE HCI transport to spi for Nina based devices#380
andreagilardoni wants to merge 7 commits intoarduino-libraries:masterfrom
andreagilardoni:ble-vhci-over-spi

andreagilardoni commented Jan 15, 2025

Uh oh!

github-actions bot commented Jan 15, 2025

Uh oh!

github-actions bot commented Jan 15, 2025

Uh oh!

andreagilardoni commented Jan 16, 2025

Uh oh!

github-actions bot commented Jan 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

andreagilardoni commented Jan 15, 2025

Uh oh!

github-actions bot commented Jan 15, 2025

Uh oh!

github-actions bot commented Jan 15, 2025

Uh oh!

andreagilardoni commented Jan 16, 2025

Uh oh!

github-actions bot commented Jan 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant