Add functions stub for compatibility with very minimal libc#188
Open
facchinm wants to merge 1 commit intoarduino:masterfrom
Open
Add functions stub for compatibility with very minimal libc#188facchinm wants to merge 1 commit intoarduino:masterfrom
facchinm wants to merge 1 commit intoarduino:masterfrom
Conversation
In case the user needs to call the functions from Print/String, these placeholders should be implemented (with C++ scope)
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #188 +/- ##
=======================================
Coverage 95.77% 95.77%
=======================================
Files 13 13
Lines 970 970
=======================================
Hits 929 929
Misses 41 41
☔ View full report in Codecov by Sentry. |
aentinger
reviewed
May 17, 2023
Contributor
aentinger
left a comment
aentinger
left a comment
There was a problem hiding this comment.
Who'd be setting that define __VERY_MINIMAL_LIBC__? Looks like a compiler-intrinsic to me (just curious).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case the user needs to call the functions from Print/String, these placeholders should be implemented (with C++ scope)