fix: respect user keybinding configuration for input_submit/input_newline#243
Open
ariane-emory wants to merge 3 commits intodevfrom
Open
fix: respect user keybinding configuration for input_submit/input_newline#243ariane-emory wants to merge 3 commits intodevfrom
ariane-emory wants to merge 3 commits intodevfrom
Conversation
…line Make hardcoded default keybindings conditional so user configuration takes precedence. User bindings now come first in the array, and defaults are only added for actions the user hasn't configured. This fixes the issue where configuring: input_newline: return input_submit: ctrl+return,alt+return,shift+return Would fail because hardcoded defaults always matched first. Changes: - Check if user has configured submit/newline actions - Only add defaults for unconfigured actions - Put user bindings first so they take precedence
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
What does this PR do?
Make hardcoded default keybindings conditional so user configuration takes precedence. User bindings now come first in the array, and defaults are only added for actions the user hasn't configured.
This fixes the issue where configuring:
input_newline: return
input_submit: ctrl+return,alt+return,shift+return,linefeed
Would fail because hardcoded defaults always matched first.
Changes: