fix(tui): move KV-persisted toggles from Session to System category#244
Open
ariane-emory wants to merge 23 commits intodevfrom
Open
fix(tui): move KV-persisted toggles from Session to System category#244ariane-emory wants to merge 23 commits intodevfrom
ariane-emory wants to merge 23 commits intodevfrom
Conversation
Move four command palette items that persist via KV store from the session route to the app level so they are available at all times: - Show/Hide timestamps - Show/Hide thinking - Show/Hide tool details - Show/Hide header These toggles persist across sessions via kv.json, so they belong in the System category and should be accessible even before a session starts. Resolves #158
…mory/opencode into feat/command-palette-consistecy
…mmand-palette-consistecy intent)
…_output to app.tsx, remove duplicates from session/index.tsx
Move the sidebar_toggle command from session/index.tsx to app.tsx to properly categorize it as a System command. The command now uses kv.get()/kv.set() to persist the sidebar visibility state across sessions, following the same pattern as other moved commands (timestamps, thinking, tool details, etc.). Changes: - Remove sidebar_toggle from session/index.tsx - Add sidebar_toggle to app.tsx with proper kv-based implementation - Update value from 'session.sidebar.toggle' to 'app.toggle.sidebar'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Move several command palette items that persist via KV store and that last through changes in sessoin to the System category for consistency:
These toggles persist across sessions, so they belong in System rather than Session group and should be available for use before a session has been started by sending a message.
Resolves #158
How did you verify your code works?
Manual A/B testing,
bun typecheck,bun test.