Register encoding options when adding the service to the service collection#1575
Open
hugohlln wants to merge 3 commits intoaws:masterfrom
Open
Register encoding options when adding the service to the service collection#1575hugohlln wants to merge 3 commits intoaws:masterfrom
hugohlln wants to merge 3 commits intoaws:masterfrom
Conversation
|
Good idea, Very usefull for webp images with api gateway. |
ashishdhingra
changed the title
dscpinheiro
changed the title
normj
requested changes
Sep 8, 2023
Member
normj
left a comment
normj
left a comment
There was a problem hiding this comment.
Thanks for the PR. I think the approach to solve the problem of configuring binary data is good. A few minor comments plus we also need some tests in the Amazon.Lambda.AspNetCoreServer.Test project.
Libraries/src/Amazon.Lambda.AspNetCoreServer/Internal/EncodingOptions.cs
Outdated
Show resolved
Hide resolved
Libraries/src/Amazon.Lambda.AspNetCoreServer/Internal/EncodingOptions.cs
Outdated
Show resolved
Hide resolved
Libraries/src/Amazon.Lambda.AspNetCoreServer.Hosting/HostingOptions.cs
Outdated
Show resolved
Hide resolved
Author
|
@normj Thanks for your feedbacks I just dit a new commit with following changes :
For unit tests, what would be the best way to test the injection of IEncodingOptions ? |
Libraries/src/Amazon.Lambda.AspNetCoreServer.Hosting/Internal/LambdaRuntimeSupportServer.cs
Outdated
Show resolved
Hide resolved
Author
|
I just moved the registration of IEncodingOptions to LambdaRuntimeSupportServer level and removed redundant code from each AbstractAspNetCoreFunction<TREQUEST, TRESPONSE> implementations (APIGatewayHttpApiV2MinimalApi, APIGatewayRestApiMinimalApi and ApplicationLoadBalancerMinimalApi) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:: #1574
Description of changes:
Can now register content type for transformation by passing options to the HostingOptions object