Use composition over inheritance in ContainerPreviewRenderer #685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The added condition for excluded cTypes prevented an early return for v13+ pageTS config handling: Per default no extra configuration is needed if items should be added. The condition is not needed at all. If the array is empty the foreach loop does nothing and the pageTs is returned. Fixes: b13#660
StandardContentPreviewRenderer now has a constructor with DI on its own. This collides with the ContainerPreviewRenderer constructor. Instead of extending the class, it is now injected as an attribute and used to implement the interface methods. Fixes: b13#682
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.