Open
Conversation
Captures the current state of the `addBreadcrumb` implementation in BacktraceBreadcrumbs in which the configuration of enabled types is not honored. For example, if a user configures breadcrumbs such that only breadcrumbs of type "MANUAL" are enabled, then (aside from the initial configuration breadcrumb which is added unconditionally) no other breadcrumb types should be added to the breadcrumb log.
This commit fixes a bug in addBreadcrumb where the enabled breadcrumb types configuration was not being consulted before adding a breadcrumb. Noticed when investigating a crash report that contained breadcrumb types that were expected to be disabled but were not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug in addBreadcrumb where the enabled breadcrumb
types configuration was not being consulted before adding a breadcrumb.
Noticed when investigating a crash report that contained breadcrumb
types that were expected to be disabled but were not.