Skip to content

Comments

chore: remove pip_repository_annotations example#3622

Open
rickeylev wants to merge 1 commit intobazel-contrib:mainfrom
rickeylev:rm.pip.repo.annotations
Open

chore: remove pip_repository_annotations example#3622
rickeylev wants to merge 1 commit intobazel-contrib:mainfrom
rickeylev:rm.pip.repo.annotations

Conversation

@rickeylev
Copy link
Collaborator

@rickeylev rickeylev commented Feb 21, 2026

This PR deletes the pip_repository_annotations example. This is
because it is a workspace-only example, and its removal is preparatory
work for dropping workspace support from rules_python.

This is a workspace-only example, and its removal is preparatory work for dropping workspace support.
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @rickeylev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the rules_python repository by eliminating an example that relied on the legacy workspace model. This action is a deliberate move to simplify the project's structure and pave the way for the eventual deprecation of workspace support, aligning the project with modern Bazel practices like Bzlmod.

Highlights

  • Example Removal: The pip_repository_annotations example has been completely removed from the codebase.
  • Workspace Support Deprecation: This removal is a preparatory step towards dropping workspace support from rules_python, as the example was workspace-only.
  • CI Configuration Update: Corresponding CI tests for the removed example have been deleted from the .bazelci/presubmit.yml file.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • .bazelci/presubmit.yml
    • Removed CI test configurations for the pip_repository_annotations example across various platforms (Ubuntu, Debian, macOS, Windows).
  • examples/pip_repository_annotations/.bazelrc
    • Deleted the Bazel configuration file specific to the pip_repository_annotations example.
  • examples/pip_repository_annotations/.gitignore
    • Deleted the .gitignore file for the pip_repository_annotations example directory.
  • examples/pip_repository_annotations/BUILD.bazel
    • Deleted the Bazel build file, which included compile_pip_requirements and py_test definitions for the example.
  • examples/pip_repository_annotations/WORKSPACE
    • Deleted the Bazel WORKSPACE file that defined the pip_parse rule with package annotations for the example.
  • examples/pip_repository_annotations/data/copy_executable.py
    • Deleted the Python script used as an executable within the example's data directory.
  • examples/pip_repository_annotations/data/copy_file.txt
    • Deleted the text file used for copying within the example's data directory.
  • examples/pip_repository_annotations/pip_repository_annotations_test.py
    • Deleted the Python test file that verified the functionality of pip_repository_annotations.
  • examples/pip_repository_annotations/requirements.in
    • Deleted the pip-compile input requirements file for the example.
  • examples/pip_repository_annotations/requirements.txt
    • Deleted the generated pip-compile output requirements lock file for the example.
  • python/private/pypi/pip_repository.bzl
    • Updated the documentation for the pip_repository rule by removing the outdated reference to the pip_repository_annotations example's WORKSPACE file.
Activity
  • rickeylev created this pull request with the title 'chore: remove pip_repository_annotations example' and provided a description explaining that the example is workspace-only and its removal is preparatory work for dropping workspace support from rules_python.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the pip_repository_annotations example, which is a workspace-only feature. This is a preparatory step for dropping workspace support from rules_python. The changes include deleting the example directory, removing the associated CI jobs, and updating a docstring to remove a link to the now-deleted example. The changes are correct and align with the stated goal. I have no further comments.

@rickeylev rickeylev enabled auto-merge February 21, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants