-
Notifications
You must be signed in to change notification settings - Fork 2k
Add remove_missing option to convert plugin #6324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
I see some failing checks on Windows, but it appears to be failing when invoking ffmpeg. I don't know if this is to be expected or not. |
|
Ok, that seemed to do the trick. I made the mistake of copying the setup from another test case that must have been trying to test something about the path encodings. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6324 +/- ##
==========================================
+ Coverage 68.78% 68.83% +0.05%
==========================================
Files 140 140
Lines 18619 18644 +25
Branches 3054 3063 +9
==========================================
+ Hits 12807 12834 +27
+ Misses 5164 5161 -3
- Partials 648 649 +1
🚀 New features to boost your workflow:
|
|
The same Windows error happens again. Can anyone help figure it out? I really don't understand why this would fail on Windows, when the "run_convert" call works in all other tests. |
Description
This PR adds a new configuration/option to the convert plugin.
The "remove_missing" option indicates that files in the convert destination directory not present in the library should be removed (asking for confirmation).
To Do
Beware that this is my first PR here, so I'm still unaware of common practices. I tried to follow the same principles that I saw in the
convert.pyfile, but I'm sure a lot of them will be outdated, feel free to suggest any changes.Also, I'm still not 100% sold on the config/option name. Let me know if you have a suggestion.