fix: stream remote io paths and benchmark decompression backends#67
Merged
fix: stream remote io paths and benchmark decompression backends#67
Conversation
Update async download to preserve raw bytes and stream cache and S3 reads instead of buffering whole payloads. Reuse default HTTP clients for blocking requests, add structured S3 status errors, expand decompression benchmarks for gzip backends and bz2, and refresh tests and changelog for the new behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Benchmarks
16 MiB generated text corpus, measured on both the raw decoder path and
oneio::get_reader.cloudflare-zlib: raw1.162 GiB/s,oneio1.135 GiB/szlib-rs: raw1.035 GiB/s,oneio1.017 GiB/szlib-ng: raw1.020 GiB/s,oneio1.014 GiB/sminiz_oxide: raw686 MiB/s,oneio680 MiB/sbz2: raw76.8 MiB/s,oneio76.9 MiB/scloudflare-zlibwas the fastest gzip backend in this run.zlib-rsandzlib-ngwere close behind and materially faster thanminiz_oxide.Example
Run the backend comparison locally:
Behavior note:
The async download now preserves the remote bytes, matching
download().