Guard missing peer addr in connect_dag assertions#798
Open
ashishkrshaw wants to merge 1 commit intobitcoin-dev-project:mainfrom
Open
Guard missing peer addr in connect_dag assertions#798ashishkrshaw wants to merge 1 commit intobitcoin-dev-project:mainfrom
ashishkrshaw wants to merge 1 commit intobitcoin-dev-project:mainfrom
Conversation
Contributor
|
Have you observed this error running the test locally or on our CI? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed a small edge case in connect_dag.py: some peer entries can have a missing or null addr, and the current assertions can crash while splitting or substring checks. This change keeps behavior the same for valid data, but adds a safe fallback using d.get('addr') or '' for both DNS and IP assertions. Also fixed a typo in the error message from conectee to connectee.