Make lnd.startupProbe overridable#799
Draft
ekzyis wants to merge 1 commit intobitcoin-dev-project:mainfrom
Draft
Make lnd.startupProbe overridable#799ekzyis wants to merge 1 commit intobitcoin-dev-project:mainfrom
ekzyis wants to merge 1 commit intobitcoin-dev-project:mainfrom
Conversation
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it possible to override
startupProbeof an LND node.This is required for bitcoin-dev-project/wrath-of-nalo#8 because lnd v0.15.5-beta does not support
macaroon_root_keyininitwallet. (Support was added in v0.16.0, see lightningnetwork/lnd#6457.I couldn't simply use
{{- toYaml .Values.startupProbe | nindent 8 }}and put the current default value into values.yaml similar tolivenessProbeetc. because{{ .Values.global.chain }}wouldn't get interpolated.This was tested by deploying the battlefield in bitcoin-dev-project/wrath-of-nalo#8 and inspecting the pod running lnd v0.15.5-beta.
TODO