Add .npmignore to make the published module smaller and work around a bug in Flow#143
Open
dumbmatter wants to merge 1 commit intobrowserify:masterfrom
Open
Add .npmignore to make the published module smaller and work around a bug in Flow#143dumbmatter wants to merge 1 commit intobrowserify:masterfrom
dumbmatter wants to merge 1 commit intobrowserify:masterfrom
Conversation
… (and to work around facebook/flow#5898)
|
looks good & would have appreciated not having to manually fix the flow error. eta? |
Member
|
Is this fixed in flow since facebook/flow@f942d96? Shipping tests and examples with packages is handy if users are working offline or if they need to debug something. |
|
@goto-bus-stop flow@0.96.0 is still identifying this as an error for me The main problem is, I have no idea why putting in my |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will make everyone's life slightly better by making the module distributed through npm a bit smaller.
And it will save users of Flow some grief, because of facebook/flow#5898.