Open
Conversation
Member
|
Well huh. Our json schema check when building the device config should've crashed the whole build on that misspelling! So there's even more bugs to fix here. Thanks for calling that out, will file that as a followup. @blackspherefollower You're up for the device impl review. |
Collaborator
blackspherefollower
left a comment
blackspherefollower
left a comment
There was a problem hiding this comment.
Minor snag on the copyright header, otherwise nice concise and clean
| @@ -0,0 +1,81 @@ | |||
| // Buttplug Rust Source Code File - See https://buttplug.io for more info. | |||
| // | |||
| // Copyright 2016-2024 Nonpolynomial Labs LLC. All rights reserved. | |||
blackspherefollower
approved these changes
Nov 26, 2025
Collaborator
|
@qdot This looks good to me: I've not updated my OSSM to the most recent firmware yet to test though |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OSSM v3 will be releasing soon...updated BLE specs are committed. No absolute positioning in this round, speed control only.
(and i noticed luvmazer had a typo)