Skip to content

fix(dependency-analysis): fix exit if override is set#36

Merged
BaptisteCentreon merged 1 commit intomainfrom
SECU-1094-extend-pnpm-to-2026-03-31
Mar 4, 2026
Merged

fix(dependency-analysis): fix exit if override is set#36
BaptisteCentreon merged 1 commit intomainfrom
SECU-1094-extend-pnpm-to-2026-03-31

Conversation

@tuntoja
Copy link
Contributor

@tuntoja tuntoja commented Mar 4, 2026

Description

PLEASE MAKE SURE THAT THE BRANCH PR INCLUDES JIRA TICKET ID (for centreon-internal)

Please include a short resume of the changes and what is the purpose of PR. Any relevant information should be added to help:

  • QA Team (Quality Assurance) with tests.
  • reviewers to understand what are the stakes of the pull request.

Fixes # (issue)

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

Target serie

  • 24.04.x
  • 24.10.x
  • 25.10.x
  • master

How this pull request can be tested ?

Please describe the procedure to verify that the goal of the PR is matched. Provide clear instructions so that it can be correctly tested.

Any relevant details of the configuration to perform the test should be added.

Checklist

Community contributors & Centreon team

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (master, maintenance).

Summary by Aikido

Security Issues: 0 Quality Issues: 0 Resolved Issues: 0

🐛 Bugfixes

  • Replaced return with exit to correctly stop workflow step

More info

@tuntoja tuntoja requested a review from a team as a code owner March 4, 2026 15:04
@tuntoja tuntoja requested a review from sc979 March 4, 2026 15:04
@github-actions
Copy link

github-actions bot commented Mar 4, 2026

Logo
Checkmarx One – Scan Summary & Details4626379e-970e-426b-b192-587ef0e050fa

Great job! No new security vulnerabilities introduced in this pull request

@tuntoja tuntoja requested a review from BaptisteCentreon March 4, 2026 15:22
@BaptisteCentreon BaptisteCentreon merged commit 94890a6 into main Mar 4, 2026
6 of 8 checks passed
@BaptisteCentreon BaptisteCentreon deleted the SECU-1094-extend-pnpm-to-2026-03-31 branch March 4, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants