ENT-13525: Refactored cfe_autorun_inventory_packages

[nickanderson]

Prior to the introduction of package promise modules CFEngine would
This bundle was originally introduced to ensure that CFEngine Enterprise had
software inventory reported immediately after initial install using the default
policy set.

With the package_module implementation mature, there is no longer need to have a
packages promise for a fake package to trigger software inventory data to be
reported so it has been removed.

Unsupported platforms that do not have a default package module for inventory
supplied will no longer have software inventory and will not be able to leverage
the packagesmatching() functions unless there is an explicit
package promise made.

Ticket: ENT-13525
Changelog: Commit

[cf-bottom]

Thank you for submitting a PR! Maybe @craigcomstock can review this?

[craigcomstock]

Issues I see:

• the changelog should not be the entire commit I would say. Instead re-word the first sentence so that it expresses the situation, something like "Disabled fake package promise to trigger packages inventory on platforms which no longer need it"
• should we really remove this feature for platforms that don't have a default package module?
• some of the commit message needs work, see below:

Prior to the introduction of package promise modules CFEngine would

This incomplete sentence is left hanging, remove it?

With the package_module implementation mature, there is no longer need to have a
packages promise for a fake package to trigger software inventory data to be
reported so it has been removed.

Maybe "Because the package_module implementation has matured, there is no longer a need to have a packages promise for a fake package ..."

Unsupported platforms that do not have a default package module for inventory
supplied will no longer have software inventory and will not be able to leverage
the packagesmatching() functions unless there is an explicit
package promise made.

But why are we removing this for platforms without a default package module? Why not leave those in place?