feat(devnet): add interactive config editor#392
Merged
Conversation
…reak devnet-config-tui.ts into 7 modules:\n- tui-state.ts: TuiState/TuiWidgets interfaces + factory\n- dialogs.ts: 4 reusable dialog primitives (input, confirm, fixed-array, array-value)\n- actions.ts: all user actions (edit, add, delete, insert, move, search, quit, save)\n- format.ts: tree-view entry line formatter\n- blessed-helpers.ts: type-safe wrapper for untyped list.selected\n- devnet-config-tui.ts: thin orchestrator (layout, refreshUi, key bindings)\n\nAlso includes bug fixes from earlier review:\n- Add dialogLock to prevent global keys firing during modal dialogs\n- Add resolved guards to prevent double-resolve in all dialogs\n- Fix Enter event bubbling in waitForInput\n- Remove list.on('select') in fixed-array dialog to prevent toggle+apply conflict\n\nOther improvements:\n- Add editor.setArrayValues() to fix encapsulation leak (was direct splice)\n- Introduce guardedKey/guardedKeyAsync helpers to eliminate repeated dialogLock checks\n- Replace closure variables with centralized TuiState object\n- Add ActionContext pattern for testable action functions"
- Add clearer section spacing with dedicated render rows - Render fixed arrays as separate detail lines - Simplify fixed-array values to bracketed list format - Tune inline docs/value colors for readability - Fix object preview format to avoid blessed tag parsing artifacts
- Fix fixed-array modal key handling (single-step navigation, esc/cmd all/none) - Bind Esc on main view to quit flow without modal re-entry - Improve confirm dialog keyboard handling (tab/shift-tab/enter variants) - Clarify unsaved-changes prompt with explicit action labels - Fix confirm button layout and focus-state consistency
- Move devnet config editor from src/node/devnet-config-editor.ts to src/devnet/config-editor.ts - Update all imports in cmd, tui, and tests - Align refactoring doc references with new module path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.