Updated Library Grouping to have "Album Artist / Album"#190
Merged
amuttsch merged 4 commits intoclementine-player:masterfrom Apr 13, 2018
Merged
Updated Library Grouping to have "Album Artist / Album"#190amuttsch merged 4 commits intoclementine-player:masterfrom
amuttsch merged 4 commits intoclementine-player:masterfrom
Conversation
Translations string XML files have been updated with the additional item under "pref_library_grouping_values" with my best guess at the translations. They have been commented, For someone who is multi-lingual to fix if needed :)
Member
|
Looks good. Please remove all translations as they will be overridden by the next transifex translation pull. Also add the feature to the |
Added Improvement to CHANGELOG
Contributor
Author
|
@amuttsch There that should be done now :) Sorry i forgot to tick all the translation files when i committed (Hence the double commit) |
Member
|
Perfect, thanks for the PR :) |
|
I was looking for the very interesting "album artist" grouping feature on Clementine Remote v12, until I realised I needed to set up my phone in English language to see the option. Seems like something went wrong, at least for the French translation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Translations string XML files have been updated with the additional item under "pref_library_grouping_values" with my best guess at the translations. They have been commented, For someone who is multi-lingual to fix if needed :)