Skip to content

Conversation

@nedaKaighobadi
Copy link
Contributor

No description provided.

@nedaKaighobadi nedaKaighobadi requested a review from a team as a code owner January 28, 2026 12:03
Copilot AI review requested due to automatic review settings January 28, 2026 12:03
@codacy-production
Copy link

codacy-production bot commented Jan 28, 2026

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for b5c45281 63.01%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (b5c4528) Report Missing Report Missing Report Missing
Head commit (c63fc03) 6073 1490 24.53%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#186) 146 92 63.01%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@codacy-production
Copy link

codacy-production bot commented Jan 28, 2026

Codacy's Analysis Summary

0 new issue (≤ 1 medium issue)
0 new security issue (≤ 0 issue)
42 complexity
0 duplications

Review Pull Request in Codacy →

AI Reviewer available: add the codacy-review label to get contextual insights without leaving GitHub.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements path escaping for special shell characters to fix issue CF-2117. The changes add proper escaping logic to handle file paths that contain spaces, quotes, and other special characters that could break shell command execution.

Changes:

  • Added preparePathForExec method in CodacyCli to escape special shell characters using backslash escaping
  • Refactored processSarifResults function into a new utils.ts file for better code organization
  • Updated WinWSLCodacyCli to properly convert and escape Windows paths for WSL execution
  • Added comprehensive test suite covering various special characters and edge cases
  • Removed unused parameters from SetupView.resolveWebviewView method

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
src/cli/CodacyCli.ts Implements base path escaping logic that escapes special shell characters
src/cli/MacCodacyCli.ts Updates import to use new utils module
src/cli/WinWSLCodacyCli.ts Refactors Windows-to-WSL path conversion and adds character escaping
src/cli/WinCodacyCli.ts Updates import to use new utils module
src/cli/index.ts Removes processSarifResults function and re-exports from utils
src/cli/utils.ts New file containing extracted processSarifResults utility function
src/test/suite/cli/pathEscaping.test.ts Comprehensive test suite for path escaping across all platforms
src/views/SetupView.ts Cleanup: removes unused interface method parameters

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings January 28, 2026 13:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants