Conversation
hannahbergam
left a comment
There was a problem hiding this comment.
I'd still like to use the enter/esc paradigm here so a user doesn't have to tab through all console logs if they're trying to navigate elsewhere!
Sounds good! Will update and also log a ticket for the current regression in Enter/Escape in the chat workspace. |
Yay thank you!! |
hannahbergam
left a comment
There was a problem hiding this comment.
One tiny wording idea but yay the screencast looks awesome! Thank you!
| isFirstLog && isLastLog | ||
| ? 'The only log entry. ' | ||
| : isFirstLog | ||
| ? 'Least recent log entry. ' |
There was a problem hiding this comment.
Is it okay if we switch this to 'oldest'?
This PR adds keyboard navigability to console logs in the Web Lab 2 console panel - the implementation is similar to the pattern used in the chat workspace.
aria-label),Note that in the chat workspace, a user doesn't have to press 'Exit' to exit out of workspace, so a ticket is logged for this: https://codedotorg.atlassian.net/browse/SL-1600
This PR also passes a custom icon for the log with
aria-hidden: trueso that the VoiceOver ignores this decorative icon and reads the message text. If this is not included, the log message is not read out load and instead VO says 'and two more items'.We should probably update the
Alertcomponent so that it accepts aniconAriaHidden. I added that as a TODO in the comment.Before update
before-update-console.mov
After update
With multiple logs with MacOS VO:
multiple-logs.mov
With only one log with MacOS VO:
one-log.mov
Links
Testing story
Tested locally on
weblab2levels with Mac Voiceover.Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Creation Checklist: