Update Definitions to Include Signature #262
Conversation
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 146 out of 148 changed files in this pull request and generated 10 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
definitions/standard/runtime_definition/control/std_control_stop.proto.json
Outdated
Show resolved
Hide resolved
definitions/standard/runtime_definition/number/std_number_ln.proto.json
Outdated
Show resolved
Hide resolved
definitions/standard/runtime_definition/array/std_array_is_empty.proto.json
Outdated
Show resolved
Hide resolved
definitions/standard/runtime_definition/object/std_object_keys.proto.json
Outdated
Show resolved
Hide resolved
definitions/standard/runtime_definition/number/std_number_from_text.proto.json
Outdated
Show resolved
Hide resolved
definitions/standard/runtime_definition/boolean/std_boolean_from_text.proto.json
Show resolved
Hide resolved
definitions/standard/runtime_definition/array/std_array_reverse.proto.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 146 out of 148 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
definitions/standard/runtime_definition/array/std_array_index_of.proto.json
Outdated
Show resolved
Hide resolved
definitions/standard/runtime_definition/number/std_number_clamp.proto.json
Outdated
Show resolved
Hide resolved
definitions/standard/runtime_definition/object/std_object_set.proto.json
Outdated
Show resolved
Hide resolved
definitions/standard/runtime_definition/boolean/std_boolean_negate.proto.json
Show resolved
Hide resolved
definitions/standard/runtime_definition/object/std_object_get.proto.json
Outdated
Show resolved
Hide resolved
cfe2026 to
745349b
Compare
Co-authored-by: Nico Sammito <nico@sammito.de> Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
…proto.json Co-authored-by: Nico Sammito <nico@sammito.de> Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
nicosammito
left a comment
There was a problem hiding this comment.
still one is wrong. Its says MNUMBER instead of NUMBER
This is fixed |
definitions/standard/runtime_definition/object/std_object_set.proto.json
Outdated
Show resolved
Hide resolved
…proto.json Co-authored-by: Nico Sammito <nico@sammito.de> Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
nicosammito
left a comment
There was a problem hiding this comment.
Looks good from a signature perspective
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 147 out of 148 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
….json Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
nicosammito
left a comment
There was a problem hiding this comment.
U are using => to signal the return type. Pls use : instead
Resolves: #256