Skip to content

Update Definitions to Include Signature #262

Open
raphael-goetz wants to merge 32 commits intomainfrom
256-update-definitions
Open

Update Definitions to Include Signature #262
raphael-goetz wants to merge 32 commits intomainfrom
256-update-definitions

Conversation

@raphael-goetz
Copy link
Member

Resolves: #256

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 146 out of 148 changed files in this pull request and generated 10 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 146 out of 148 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
@raphael-goetz raphael-goetz marked this pull request as ready for review March 4, 2026 13:56
@raphael-goetz raphael-goetz force-pushed the 256-update-definitions branch 2 times, most recently from cfe2026 to 745349b Compare March 5, 2026 20:09
raphael-goetz and others added 2 commits March 5, 2026 21:10
Co-authored-by: Nico Sammito <nico@sammito.de>
Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
…proto.json

Co-authored-by: Nico Sammito <nico@sammito.de>
Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
Copy link
Contributor

@nicosammito nicosammito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still one is wrong. Its says MNUMBER instead of NUMBER

@raphael-goetz
Copy link
Member Author

still one is wrong. Its says MNUMBER instead of NUMBER

This is fixed

…proto.json

Co-authored-by: Nico Sammito <nico@sammito.de>
Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
Copy link
Contributor

@nicosammito nicosammito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a signature perspective

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 147 out of 148 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

raphael-goetz and others added 2 commits March 8, 2026 17:21
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
….json

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
Copy link
Contributor

@nicosammito nicosammito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

U are using => to signal the return type. Pls use : instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update all Definitions to Latest Tucana Version

3 participants