REST will return Json instead of ProtoJson #164
Merged
raphael-goetz merged 3 commits intomainfrom Mar 1, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the REST adapter response serialization so that protobuf Value payloads are converted into standard JSON output (instead of protobuf’s kind-shaped “proto-json”), addressing issue #161.
Changes:
- Added a
pb_value_to_jsonconverter fromtucana::shared::Valuetoserde_json::Value. - Updated the response payload serialization path to serialize the converted JSON value.
Comments suppressed due to low confidence (1)
adapter/rest/src/main.rs:251
- The successful response path serializes
payloadto JSON bytes but does not ensure aContent-Type: application/jsonheader is present (unlikejson_error). If flows omit this header, clients may not treat the body as JSON; consider adding a defaultcontent-typewhen building the response (without overriding an explicit flow-provided value).
// payload -> json bytes
let json_val = pb_value_to_json(payload_val);
let json = serde_json::to_vec_pretty(&json_val).unwrap_or_else(|err| {
format!(r#"{{"error":"Serialization failed: {:?}"}}"#, err).into_bytes()
});
let status =
StatusCode::from_u16(code as u16).unwrap_or(StatusCode::INTERNAL_SERVER_ERROR);
build_response(status, http_headers, json)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #161