Skip to content

Cleanup sdk#2

Open
Knerio wants to merge 2 commits intomainfrom
update-to-simpler-types
Open

Cleanup sdk#2
Knerio wants to merge 2 commits intomainfrom
update-to-simpler-types

Conversation

@Knerio
Copy link
Member

@Knerio Knerio commented Mar 9, 2026

No description provided.

@Knerio Knerio requested a review from nicosammito March 9, 2026 21:40
@Knerio Knerio self-assigned this Mar 9, 2026
const sdk = createSdk({
token: "your_token_here",
token: randomUUID(),
actionUrl: "127.0.0.1:50051",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be named differently

token: "your_token_here",
token: randomUUID(),
actionUrl: "127.0.0.1:50051",
actionId: "action_123",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this id come from?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its just an auth token currently just an random identifier for the test server

Comment on lines 13 to 17
sdk.registerConfigDefinitions({
type: {
signature: "string",
identifier: "STRING",
version: "0.0.0",
rules: [],
name: [],
genericKeys: [],
alias: [],
displayMessage: [],
linkedDataTypeIdentifiers: [],
definitionSource: ""
},
name: [],
description: [],
type: "LIST<STRING>",
linkedDataTypeIdentifiers: ["STRING", "LIST"],
identifier: "config_discord_bot_token",
})

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be parsed in as the root sdk object


sdk.registerDataType({
identifier: "SOME_DATATYPE",
signature: "any",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its named type not signature

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should discuss this naming in tucana then

signature: "(n: NUMBER) => NUMBER",
definitionSource: "",
linkedDataTypeIdentifiers: ["NUMBER"],
runtimeParameterDefinitions: [

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its should be named simply parameters

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tucana naming

@@ -55,46 +34,23 @@ sdk.registerFunctionDefinition(
defaultValue: constructValue(20),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just put in 20

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can change it

displayIcon: "",
displayMessage: [],
editable: false,
inputTypeIdentifier: "STRING",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be named inputType

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tucana

alias: [],
identifier: "test_flow",
settings: [],
version: "0.0.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version is absolute here, because its the same as in sdk

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants