Conversation
…nil to avoid uncaught exception Previously, if the model defined no sets, and a client asked for them, an uncaught exception would be raised, `NoMethodError: undefined method `detect' for nil` By making the default return `[]` instead of `nil`, it changes to an appropriate `OAI::NoMatchException` which is rescued properly by controller etc. I do not use sets, and am not totally sure functionality is working if you do, haven't tracked down a list. But pretty sure this wont' break anything.
c76b4f9 to
4fe86b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if the model defined no sets, and a client asked for them, an uncaught exception would be raised,
NoMethodError: undefined methoddetect' for nil`With a pretty darn confusing stack trace
By making the default return
[]instead ofnil, it changes to an appropriateOAI::NoMatchExceptionwhich is rescued properly by controller to return this response:I don't know if it's ideal, but seems to be what was intended.
I do not use sets, and am not totally sure functionality is working if you do, haven't tracked down a test and the code isn't looking great to me -- But pretty sure this change won't break anything, a
setsmethod that was defined, as modelled, seems like[]would be a legal return value. But maybe notnil.Got to the bottom of this after local error: sciencehistory/scihist_digicoll#2911