-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[OPIK-1491] [FE] Make reason field always visible in Annotate #4971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[OPIK-1491] [FE] Make reason field always visible in Annotate #4971
Conversation
|
🔄 Test environment deployment process has started Phase 1: Deploying base version You can monitor the progress here. |
|
❌ Test environment deployment failed The deployment encountered an error. Please check the deployment logs for details. |
|
✅ Test environment is now available! To configure additional Environment variables for your environment, run [Deploy Opik AdHoc Environment workflow] (https://github.com/comet-ml/comet-deployment/actions/workflows/deploy_opik_adhoc_env.yaml) Access Information
The deployment has completed successfully and the version has been verified. |
andriidudar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good overall — nice work 👍
I did notice one functional issue, though. In some cases the behavior isn’t quite correct. For example, it’s currently possible to type a reason without setting the required value, which can lead to a server error.
To prevent this, it might be better to disable the Reason field until a value is selected.
...end/src/components/pages-shared/traces/TraceDetailsPanel/TraceAnnotateViewer/AnnotateRow.tsx
Show resolved
Hide resolved
4b5efd1 to
9f2002e
Compare
9f2002e to
1c6337b
Compare
|
🔄 Test environment deployment process has started Phase 1: Deploying base version You can monitor the progress here. |
|
✅ Test environment is now available! To configure additional Environment variables for your environment, run [Deploy Opik AdHoc Environment workflow] (https://github.com/comet-ml/comet-deployment/actions/workflows/deploy_opik_adhoc_env.yaml) Access Information
The deployment has completed successfully and the version has been verified. |
Details
This PR makes the reason field always visible in the Annotate viewer instead of requiring users to click a toggle button to show it.
Screen.Recording.2026-01-28.at.15.49.24.mov
Changes:
editReasonstate andtoggleEditReasonHandlerfunction as they're no longer neededThis improves UX by making the reason field immediately discoverable and accessible without an extra click.
Change checklist
Issues
Testing
Documentation
N/A