Skip to content

Conversation

@BorisTkachenko
Copy link
Contributor

Details

This PR makes the reason field always visible in the Annotate viewer instead of requiring users to click a toggle button to show it.

Screen.Recording.2026-01-28.at.15.49.24.mov

Changes:

  • Removed the toggle button (MessageSquareMore icon) that previously controlled reason field visibility
  • The reason textarea is now always rendered below each feedback score row
  • Removed the editReason state and toggleEditReasonHandler function as they're no longer needed
  • Adjusted grid layout in FeedbackScoresEditor from 4 columns to 3 columns to account for the removed toggle button column

This improves UX by making the reason field immediately discoverable and accessible without an extra click.

Change checklist

  • User facing
  • Documentation update

Issues

  • OPIK-1491

Testing

  • Verify the reason field appears below each feedback score row in the Annotate panel
  • Verify reason can be typed, saved, copied, and cleared
  • Verify existing reasons are displayed correctly
  • Verify the layout looks correct without the toggle button column

Documentation

N/A

@BorisTkachenko BorisTkachenko self-assigned this Jan 28, 2026
@BorisTkachenko BorisTkachenko added the test-environment Deploy Opik adhoc environment label Jan 28, 2026
@github-actions
Copy link
Contributor

🔄 Test environment deployment process has started

Phase 1: Deploying base version 1.9.102-4026 (from main branch) if environment doesn't exist
Phase 2: Building new images from PR branch boryst/OPIK-1491-fe-make-reason-field-always-visible-in-annotate
Phase 3: Will deploy newly built version after build completes

You can monitor the progress here.

@CometActions
Copy link
Collaborator

Test environment deployment failed

The deployment encountered an error. Please check the deployment logs for details.

@BorisTkachenko BorisTkachenko marked this pull request as ready for review January 28, 2026 17:18
@BorisTkachenko BorisTkachenko requested a review from a team as a code owner January 28, 2026 17:18
@CometActions
Copy link
Collaborator

Test environment is now available!

To configure additional Environment variables for your environment, run [Deploy Opik AdHoc Environment workflow] (https://github.com/comet-ml/comet-deployment/actions/workflows/deploy_opik_adhoc_env.yaml)

Access Information

The deployment has completed successfully and the version has been verified.

Copy link
Contributor

@andriidudar andriidudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good overall — nice work 👍

I did notice one functional issue, though. In some cases the behavior isn’t quite correct. For example, it’s currently possible to type a reason without setting the required value, which can lead to a server error.

To prevent this, it might be better to disable the Reason field until a value is selected.

@BorisTkachenko BorisTkachenko force-pushed the boryst/OPIK-1491-fe-make-reason-field-always-visible-in-annotate branch from 4b5efd1 to 9f2002e Compare January 29, 2026 09:33
@BorisTkachenko BorisTkachenko force-pushed the boryst/OPIK-1491-fe-make-reason-field-always-visible-in-annotate branch from 9f2002e to 1c6337b Compare January 29, 2026 09:37
@BorisTkachenko BorisTkachenko added test-environment Deploy Opik adhoc environment and removed test-environment Deploy Opik adhoc environment labels Jan 29, 2026
@github-actions
Copy link
Contributor

🔄 Test environment deployment process has started

Phase 1: Deploying base version 1.9.102-4026 (from main branch) if environment doesn't exist
Phase 2: Building new images from PR branch boryst/OPIK-1491-fe-make-reason-field-always-visible-in-annotate
Phase 3: Will deploy newly built version after build completes

You can monitor the progress here.

@CometActions
Copy link
Collaborator

Test environment is now available!

To configure additional Environment variables for your environment, run [Deploy Opik AdHoc Environment workflow] (https://github.com/comet-ml/comet-deployment/actions/workflows/deploy_opik_adhoc_env.yaml)

Access Information

The deployment has completed successfully and the version has been verified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Frontend test-environment Deploy Opik adhoc environment typescript *.ts *.tsx

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants