Skip to content

fix(export): use extensionName for services schema prefix instead of metaExtensionName #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pyramation merged 1 commit into from
Mar 16, 2026
Merged

fix(export): use extensionName for services schema prefix instead of metaExtensionName #827

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions pgpm/core/src/export/export-migrations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,11 @@ const exportMigrationsToDisk = async ({

const metaReplacer = makeReplacer({
schemas: metaSchemasForReplacement,
name: metaExtensionName
name: metaExtensionName,
// Use extensionName for schema prefix — the services metadata references
// schemas owned by the application package (e.g. agent_db_auth_public),
// not the services package (agent_db_services_auth_public)
schemaPrefix: name
});

// Create separate files for each table type
Expand Down Expand Up @@ -527,6 +531,14 @@ interface Schema {
interface MakeReplacerOptions {
schemas: Schema[];
name: string;
/**
* Optional prefix for schema name replacement.
* When provided, schema names are replaced using this prefix instead of `name`.
* This is needed for the services/meta package where `name` is the services
* extension name (e.g. "agent-db-services") but schemas should use the
* application extension prefix (e.g. "agent-db" → "agent_db_auth_public").
*/
schemaPrefix?: string;
}

interface ReplacerResult {
Expand Down Expand Up @@ -606,11 +618,12 @@ const preparePackage = async ({
/**
* Generates a function for replacing schema names and extension names in strings.
*/
const makeReplacer = ({ schemas, name }: MakeReplacerOptions): ReplacerResult => {
const makeReplacer = ({ schemas, name, schemaPrefix }: MakeReplacerOptions): ReplacerResult => {
const replacements: [string, string] = ['constructive-extension-name', name];
const prefix = schemaPrefix || name;
const schemaReplacers: [string, string][] = schemas.map((schema) => [
schema.schema_name,
toSnakeCase(`${name}_${schema.name}`)
toSnakeCase(`${prefix}_${schema.name}`)
]);

const replace: [RegExp, string][] = [...schemaReplacers, replacements].map(
Expand Down
Loading