Fix external kernel memory region calculation#495
Merged
slp merged 1 commit intocontainers:mainfrom Jan 9, 2026
Merged
Conversation
ericcurtin
requested review from
MatiasVara,
jakecorrenti,
mtjhrc,
slp and
tylerfanelli
as code owners
The external kernel payload type was not passing the firmware size to the architecture-specific memory region calculation function. This could lead to incorrect memory layout when using external kernels with firmware. The change ensures the firmware size is properly accounted for in the memory region setup. This inconsistency caused VM creation to fail with HV_DENIED (-85377017) on macOS when using direct kernel boot with the Hypervisor.framework. Signed-off-by: Eric Curtin <eric.curtin@docker.com>
Member
Author
Collaborator
|
TBH, I haven't considered the possibility of preloading a firmware AND a kernel, since usually the first is there just to load the second, but I guess there may be use cases where you want both (something we need to consider before dropping the EFI flavor, since the current API doesn't allow for it). Thanks @ericcurtin ! |
slp
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The external kernel payload type was not passing the firmware size to the architecture-specific memory region calculation function. This could lead to incorrect memory layout when using external kernels with firmware. The change ensures the firmware size is properly accounted for in the memory region setup. This inconsistency caused VM creation to fail with HV_DENIED (-85377017) on macOS when using direct kernel boot with the Hypervisor.framework.