Add custom names for fields in database#504
Open
xelab04 wants to merge 6 commits intocot-rs:masterfrom
Open
Conversation
github-actions
bot
added
C-cli
m4tx
requested changes
Mar 13, 2026
Member
m4tx
left a comment
m4tx
left a comment
There was a problem hiding this comment.
Looks good to me; please have a look at the comment I left on the keywords.rs file, and at the CI results and fix the test that's failing now. Don't worry about the semver compatibility check; it's fine to break cot-codegen APIs.
After this is fixed, we'll be ready to merge the PR!
| @@ -1,4 +1,4 @@ | |||
| use cot::db::{Auto, model}; | |||
| use cot::db::{Auto, ForeignKey, model}; | |||
Member
There was a problem hiding this comment.
Seems like this file was changed probably because after merging 3bdb47a - please restore it to the original state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #486