Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
The pull request effectively addresses the identified performance overhead from eager logging by introducing a Lazy type and downgrading a frequently called log level. The changes are well-implemented and include unit tests for the new Lazy type. The use of Lazy for payload.body_to_string() is a good optimization, and the log level adjustment for computed deadline will reduce CPU burn. No critical issues found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To my surprise do
tracingmacros not lazily evaluate expressions. So in following code:payload.body_to_string()always gets evaluated but theDisplayimplementation of the resultingStringgets called only when the log is enabled.This leads to the autopilot currently spending ~2% of the time in
body_to_string().To address this I introduced the
Lazytype that delays the execution of the passed in expression to when thetracingmachinery actually executed theDisplayorDebugfunctionality.Additionally flamegraphs showed that the driver is currently burning 2.2% of its CPU time on logging auction deadlines. I downgraded that log to
tracesince it's not really that useful.Changes
used
Lazyin the autopilotdowngraded expensive log to
traceTest
Manually tested that
body_to_string()does not get called by injecting apanic!()without causing tests to failadded unit tests for
Lazyinobservecrate