WIP: DIY pagination#64
Open
krlmlr wants to merge 2 commits intocscheid:masterfrom
krlmlr:feature/30-pagination
Open
WIP: DIY pagination#64krlmlr wants to merge 2 commits intocscheid:masterfrom krlmlr:feature/30-pagination
krlmlr wants to merge 2 commits intocscheid:masterfrom
krlmlr:feature/30-pagination
Conversation
Owner
|
This one requires a bit more careful of a review, and it's unlikely I'll get to it before thursday or so next week. Ok? |
added 2 commits
April 2, 2016 09:22
Author
|
This needs a bit of work from me, I just wanted to know if you like the design or if you prefer something completely different. |
Owner
|
Oof, this completely fell off the radar for me. Thanks for the bump. I'll be looking at it this week. |
Owner
|
@jennybc, since you're a user of rgithub and a much better R developer than me, I'd love to hear your thoughts on this PR. |
Author
|
Just tried it again for pull requests, still works for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rough draft for pagination as suggested by @jennybc.
Use case:
This is strictly in a "works for me" state. Possible extensions:
fetch.page(page = "next"), also allow specifying a page numberfetch.all.pages()asstraightforwardextension (needs argwarn = FALSEinfetch.page())get.page.count(request)so thatfetch.all.pages()can show a progress barDo we want to follow the approach sketched here?
Fixes #30.