Open
Conversation
…ra code from sample
…responding source info
|
Thank you for sharing these changes. I was just about to implement similar functionality myself. In my case, the content at the source periodically changes, but the URL doesn't and prior to this, there was no easy way to clean out the cache to force it to download new. |
|
good news . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I added a couple of things that I needed so just wanted to see if you want them in original project as well. If not, nvm :)
I wanted to be able to:
I've noticed a problem - it seems that the info storage entries are never removed, even if the corresponding video is removed from cache. The entries may be small, but even if it takes thousands, it's a risk I can't take, so I had both of those operations above do the full storage clear and sigle entry clear respectively. I didn't try to implement this when the normal removal of old cached files is done, the "clear entire cache" thingy is enough for me, since I call that periodically.